Replace Buefy Taginput and Taglist component #1007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannyle
force-pushed
the
feature/replace-buefy-taginput
branch
from
e6db84e to
daf97e9
Compare
hannyle
changed the title
hannyle
changed the title
blankdots
previously approved these changes
Mar 6, 2023
csc-felipe
reviewed
Mar 6, 2023
csc-felipe
previously requested changes
Mar 6, 2023
Contributor
csc-felipe
left a comment
csc-felipe
left a comment
There was a problem hiding this comment.
This is really nice!
Just a couple of minor comments:
- It would be nice if the taginput would have an on-focus border like the other inputs
- It would also be nice if the keys that trigger a tag to be created would continue to be the same
- I noticed there was still a
b-taglistincomponents/SharedDetails.vue. Could it be changed as well?
hannyle
force-pushed
the
feature/replace-buefy-taginput
branch
from
daf97e9 to
7828be8
Compare
Contributor
Author
--> This is now fixed!
--> I brought back all the Keys that we previously had :)
--> I explained this in the Mentions, the |
hannyle
dismissed
csc-felipe’s stale review
I fixed and commented about your requested changes :)
Contributor
Sorry I missed that |
csc-felipe
reviewed
Mar 7, 2023
csc-felipe
reviewed
Mar 7, 2023
csc-felipe
dismissed
their stale review
as we're migrating to csc-ui, let's use darker borders by default, as it is in csc-ui
Contributor
Author
|
TagInput's border color is set to dark color by default now. |
csc-felipe
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replacing Buefy Taginput and Taglist component by our own component based on csc-ui Tag
Related issues
GL issue 944
Type of change
Changes Made
<b-taginput>component and be reusable in other components/viewsTesting
Mentions
As part of PR #1006
I didn't make changes for
SharedDetailscomponent since it is removed